feat(ui): inline page preview on wiki-link hover (#421)#79
Open
advancedresearcharray wants to merge 12 commits into
Open
feat(ui): inline page preview on wiki-link hover (#421)#79advancedresearcharray wants to merge 12 commits into
advancedresearcharray wants to merge 12 commits into
Conversation
Show Obsidian-style page previews on wiki-link hover using Radix HoverCard, lazy /api/kiwi/peek fetches with deduplicated caching, and touch-device detection to skip hover on coarse pointers. Co-authored-by: Cursor <cursoragent@cursor.com>
Peer review follow-up: local-notes markdown anchor renderer now omits the react-markdown node prop before forwarding attrs to hover preview. Co-authored-by: Cursor <cursoragent@cursor.com>
Peer review: pass through the original #kiwi: / #kiwi-missing: href from remark-wiki-links instead of reconstructing page paths on the underlying anchor element. Signed-off-by: Array Fleet <fleet@advancedresearcharray.local> Co-authored-by: Cursor <cursoragent@cursor.com>
Spread remark attrs before explicit href/onClick/className so markdown plugin props cannot override navigation or hover handlers. Peer review approved; 18/18 UI tests and peek API tests pass. Signed-off-by: Array Fleet <fleet@advancedresearcharray.local> Co-authored-by: Cursor <cursoragent@cursor.com>
…ew delivery Co-authored-by: Cursor <cursoragent@cursor.com>
…iwifs#421) Peer review found clearWikiLinkPeekCache() could be undone by peek responses started before navigation. Add cacheGeneration guard and regression test; align cross-page anchor scroll delay with KiwiPage. Co-authored-by: Cursor <cursoragent@cursor.com>
…wifs#421) Extract allowHoverCardOpenChange() with unit tests and fix anchor title prop order so missing-link tooltips are not overridden by remark attrs. Co-authored-by: Cursor <cursoragent@cursor.com>
Hands-on takeover re-ran full UI and Go peek tests, completed peer review, and logged verified delivery for the hover preview feature. Co-authored-by: Cursor <cursoragent@cursor.com>
…ew verification Co-authored-by: Cursor <cursoragent@cursor.com>
Record rebase onto main, onWikiLinkClick wiring, and test verification. Co-authored-by: Cursor <cursoragent@cursor.com>
…-on takeover Log green test run (28 wikiLink + 211 UI + peek API) and fleet delivery verification. Co-authored-by: Cursor <cursoragent@cursor.com>
advancedresearcharray
force-pushed
the
feat/issue-421-wiki-link-hover-preview-clean
branch
from
62ee095 to
ef83881
Compare
Re-ran wikiLink and full UI test suites plus Go peek tests; documents hands-on verification before publishing PR for wiki-link hover preview. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream: kiwifs#421
Summary
[[wiki-link]]anchors in read/preview mode using RadixHoverCardGET /api/kiwi/peekwith cache, in-flight dedup, and stale-write guardsmain(includes feat(ui): embeddable npm package @kiwifs/ui with headless components kiwifs/kiwifs#460 embeddable@kiwifs/ui); preservesonWikiLinkClickfor headless consumersTest plan
cd ui && npm test -- --run wikiLink— 28/28 passedcd ui && npm test -- --run— 211/211 passedgo test ./internal/mcpserver/ -run 'TestPeek|TestToolHandler_Peek'— passedCloses kiwifs#421 (when merged upstream)