fix(workspace): harden runbook init with embed filter and service stubs (#325)#82
Open
advancedresearcharray wants to merge 4 commits into
Open
fix(workspace): harden runbook init with embed filter and service stubs (#325)#82advancedresearcharray wants to merge 4 commits into
advancedresearcharray wants to merge 4 commits into
Conversation
…bs (kiwifs#325) Wrap embedded templates with filteredTemplatesFS to exclude legacy runbook dirs that break kiwifs check, and add service stub pages for wiki links referenced by the example runbook frontmatter. Co-authored-by: Cursor <cursoragent@cursor.com>
…wifs#325) Co-authored-by: Cursor <cursoragent@cursor.com>
…ry v3 (kiwifs#325) Record verification of embed filter, service stubs, and full test suite after fleet takeover. Closes delivery gap from prior agent run. Co-authored-by: Cursor <cursoragent@cursor.com>
Record full test verification and peer-review pass after fleet takeover. Code delivery in 59d7fd7 (embed filter + service stubs) unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filteredTemplatesFSsogo:embed all:templatesdoes not ship legacy runbook dirs (incidents/,postmortems/,procedures/) or dev-only paths that breakkiwifs checkvia placeholder wiki linksservices/api-service.mdandservices/monitoring.mdstubs soexample-high-cpu.mdfrontmatter wiki links resolve in generated scaffoldsCompletes kiwifs#325 (UC-6 runbook init template was already on main; this PR hardens embed filtering and service wiki-link targets).
Test plan
go test ./internal/workspace/... ./cmd/... -run 'Runbook|runbook|Embed|embed' -count=1go test ./... -count=1TestRunbookInitCheckPasses—kiwifs checkexits 0 on generated runbook scaffoldTestRunbookEmbedUsesUC6ScaffoldOnly— legacy embed paths excludedTestInitRunbookTemplateScaffold— service stubs present, legacy dirs absentkiwifs init --template runbook+kiwifs checkexit 0