feat(ui): keyboard shortcut cheat sheet overlay#85
Open
advancedresearcharray wants to merge 6 commits into
Open
feat(ui): keyboard shortcut cheat sheet overlay#85advancedresearcharray wants to merge 6 commits into
advancedresearcharray wants to merge 6 commits into
Conversation
Add searchable CommandDialog overlay for keyboard shortcuts, triggered by ? (outside inputs) or mod+/. Includes platform-aware kbd labels, live bindings from useKeybindings, HelpCircle toolbar button, and regression tests for overlay toggle and global shortcut suppression. Closes kiwifs#428 Signed-off-by: Array Fleet <fleet@advancedresearcharray.local>
Prevent stacked CommandDialog focus traps by closing search and new-page modals when the keyboard shortcut cheat sheet opens. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…hortcuts Log green test runs (63 targeted, 239 full suite) before PR publish. Signed-off-by: Array Fleet <fleet@advancedresearcharray.local> Co-authored-by: Cursor <cursoragent@cursor.com>
Re-ran UI test suite (63 targeted + 239 full) and documented fork push status; upstream PR blocked by read-only repo permissions. Signed-off-by: Array Fleet <fleet@advancedresearcharray.local> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?(outside inputs) andCmd+//Ctrl+/useKeybindings()config, grouped by Navigation / Views / Editor with platform-aware<kbd>labelsUpstream: kiwifs#428
Test plan
cd ui && npm test -- --run src/lib/keyboardShortcutsOverlay.test.ts src/lib/kiwiKeybindings.test.ts src/lib/overlayDismiss.test.ts— 63/63 PASScd ui && npm test -- --run— 239/239 PASS?outside an input → overlay opens with grouped shortcutsCmd+/(macOS) orCtrl+/(Linux/Windows) → overlay togglesMade with Cursor