is_user_allowed_to docstring - #1056
Open
armanddidierjean wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
=======================================
Coverage 84.99% 84.99%
=======================================
Files 220 220
Lines 16273 16273
=======================================
Hits 13831 13831
Misses 2442 2442 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Marc-Andrieu
approved these changes
Aug 25, 2026
| * make sure the user has the permission with the given name | ||
| * return the corresponding user `models_users.CoreUser` object | ||
|
|
||
| The user need to have at least ONE of the permissions in the list to be allowed to access the endpoint. |
Member
There was a problem hiding this comment.
"The user needs" with a final "s"
Maybe also add the words "logical OR" to be even more direct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Explain that users need at least one valid permission to access the endpoint
Replace
+=byextendas addition between lists is considered a bad practice in terms of performanceClassification
Type of Change
Impact & Scope
Testing
Documentation
"Docstrings#Inline comments