Skip to content

CDR: numeric documents signature using Documenso - #1057

Open
armanddidierjean wants to merge 1 commit into
mainfrom
cdr-signature
Open

CDR: numeric documents signature using Documenso#1057
armanddidierjean wants to merge 1 commit into
mainfrom
cdr-signature

Conversation

@armanddidierjean

@armanddidierjean armanddidierjean commented Aug 25, 2026

Copy link
Copy Markdown
Member

Description

Summary

Start Documenso signature flow when a document validated product is purchased. Required document must be signed for the product to be validated

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@armanddidierjean
armanddidierjean force-pushed the cdr-signature branch 3 times, most recently from c8a1fda to a6a69de Compare August 25, 2026 20:41
@armanddidierjean
armanddidierjean marked this pull request as ready for review August 25, 2026 21:34
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.93%. Comparing base (e9b5f53) to head (ccfb659).

Files with missing lines Patch % Lines
app/modules/cdr/utils_cdr.py 69.56% 7 Missing ⚠️
app/core/users/cruds_users.py 61.53% 5 Missing ⚠️
app/modules/cdr/cruds_cdr.py 42.85% 4 Missing ⚠️
app/modules/cdr/endpoints_cdr.py 73.33% 4 Missing ⚠️
app/modules/cdr/exception_cdr.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   84.99%   84.93%   -0.06%     
==========================================
  Files         220      220              
  Lines       16273    16335      +62     
==========================================
+ Hits        13831    13874      +43     
- Misses       2442     2461      +19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant