Use two TestClient fixtures, raising or not exceptions in tests - #1058
Open
armanddidierjean wants to merge 1 commit into
Open
Use two TestClient fixtures, raising or not exceptions in tests#1058armanddidierjean wants to merge 1 commit into
armanddidierjean wants to merge 1 commit into
Conversation
instead of never raising exceptions. We may want to not raise exception and instead return a proper 500 response to assert that an InternalServerError happens in specific situations But raising exception should be the usual default, as InternalServerError should rarely be expected to happen. Raising the exception allows it to be logged by pytest and make debugging easier
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
=======================================
Coverage 84.99% 84.99%
=======================================
Files 220 220
Lines 16273 16273
=======================================
Hits 13831 13831
Misses 2442 2442 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Use two TestClient fixtures, raising or not exceptions in tests instead of never raising exceptions.
We may want to not raise exception and instead return a proper 500 response to assert that an InternalServerError happens in specific situations But raising exception should be the usual default, as InternalServerError should rarely be expected to happen. Raising the exception allows it to be logged by pytest and make debugging easier
Classification
Type of Change
Impact & Scope
Testing
Documentation
"Docstrings#Inline comments