Skip to content

[CLIENT-4702] Test API doc code examples for aerospike.exception, aerospike.GeoJSON, aerospike.predicates, and aerospike.Query#1096

Draft
juliannguyen4 wants to merge 129 commits into
devfrom
CLIENT-4702-doc-validate-code-examples-using-doctest-part2
Draft

[CLIENT-4702] Test API doc code examples for aerospike.exception, aerospike.GeoJSON, aerospike.predicates, and aerospike.Query#1096
juliannguyen4 wants to merge 129 commits into
devfrom
CLIENT-4702-doc-validate-code-examples-using-doctest-part2

Conversation

@juliannguyen4

@juliannguyen4 juliannguyen4 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

TODO

  • doc/examples needs to be tested. I overlooked this in the first PR

…- this may make cicd check redundant in doc tests.
…the TLS test which needs to be run with a different job
…uple that contains the line number where it happened which isn't important
… run boilerplate code before each example in client.rst
…y code example. It doesn't seem possible with doctest + unittest
…ode example doesn't show the MAC address anymore.
…t the zero result codes from put and append.
@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.46%. Comparing base (79c6dfe) to head (a550a6e).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1096   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files          99       99           
  Lines       14090    14090           
=======================================
  Hits        11901    11901           
  Misses       2189     2189           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

juliannguyen4 added a commit that referenced this pull request Jun 5, 2026
…st to check that code examples are valid using doctest (#1047)

This addresses all the code examples in aerospike_helpers, as well as most of the code examples for aerospike and aerospike.Client.

There are still some code examples aren't tested yet e.g because they are incomplete, require EE features, or I didn't have time to get to the remaining code examples in time for the next client release. There is another PR to address those: #1096

Extra Changes:

- Replaced the code example for client.udf_put(), client.udf_list(), and client.udf_remove() with a higher level code example for the "User Defined Functions" section. The latter is verified to run without errors using doctest and demonstrates the outcomes of those API calls.
- Add ability to copy code examples while also stripping any characters that aren't valid Python syntax
- Remove bad code example for HyperLogLog class. Normally, HyperLogLog bins are created using operations or expressions.

Known issues introduced here

Documentation for aerospike.Client: The testsetup code block isn't visible by default, so we have to have a duplicate codeblock to show that code. This introduces some technical debt, and having the testsetup code visible is a missing feature in Sphinx: sphinx-doc/sphinx#3247
Base automatically changed from CLIENT-4702-doc-validate-code-examples-using-doctest to dev June 5, 2026 15:15
@juliannguyen4 juliannguyen4 changed the title [CLIENT-4702] Address remaining code examples for aerospike.exception, aerospike.GeoJSON, aerospike.predicates, and aerospike.Query [CLIENT-4702] Test API doc code examples for aerospike.exception, aerospike.GeoJSON, aerospike.predicates, and aerospike.Query Jun 5, 2026
…ectives. TODO see if there's a way to dynamically add these testcode blocks using the code examples in doc/examples.
…x doctest plugin to pick up. Delete the example python scripts now that they are inlined in the rst files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants