Correct EventObject PlayAnimation method - #1851
Conversation
These are 3 uints, using registers `edx`, `r8d` and `r9d`.
|
Pushed the added fields as b8e89ba to the main branch and fixed parameter types of the PlayAnimation method. In regards to hooking it in a plugin, there should be no issues since the last parameter is entirely unused. |
Breaking ChangesMember exists in left but not in rightFFXIVClientStructs.FFXIV.Client.Game.Object.EventObject.Delegates: 1PlayAnimation: 2
FFXIVClientStructs.FFXIV.Client.Game.Object: 1EventObject: 1
|
|
@MnFeN Are you happy with the documentation I added to main now, or is there something else we want to integrate from this PR? |
It looks nice. By the way, based on your observation, could you explain why the |
That's still confusing for me too, sorry! My theory is that it's some kind of arbitrary variable that's somewhat correlated to the animations played, because parts of the code check if a different But then you'll encounter cases like I would love to see a better breakdown of this system because its strange that they would have two variables that mean similar but slightly different things. That would involve staring at what retail does for a while though :-D |
No description provided.