528 move serialization to aether miscpp

.clang-tidy

@@ -23,6 +23,7 @@ Checks:
   - -misc-use-internal-linkage
   - -misc-use-anonymous-namespace
   - -misc-include-cleaner
+  - -misc-static-assert
   - -cppcoreguidelines-pro-type-vararg
   - -cppcoreguidelines-non-private-member-variables-in-classes
   - -cppcoreguidelines-special-member-functions
@@ -32,6 +33,7 @@ Checks:
   - -cppcoreguidelines-pro-type-member-init
   - -cppcoreguidelines-owning-memory
   - -cppcoreguidelines-avoid-const-or-ref-data-members
+  - -cppcoreguidelines-avoid-c-arrays
   - -cppcoreguidelines-macro-usage
   - -cppcoreguidelines-pro-bounds-constant-array-index
   - -cppcoreguidelines-pro-bounds-array-to-pointer-decay

aether/CMakeLists.txt

@@ -167,7 +167,6 @@ list(APPEND aether_srcs
 list(APPEND aether_srcs
             "api_protocol/protocol_context.cpp"
             "api_protocol/api_pack_parser.cpp"
-            "api_protocol/child_data.cpp"
             "api_protocol/return_result_api.cpp"
             )
 

aether/ae_actions/telemetry.cpp

@@ -19,11 +19,12 @@
 #if defined TELEMETRY_ENABLED
 
 #  include "aether-miscpp/format/format.h"
+#  include "aether-miscpp/serialization/binary_archive.h"
+#  include "aether-tele/traps/statistics_trap.h"
+
 #  include "aether/aether.h"
 #  include "aether/tele_statistics.h"
-
-#  include "aether/mstream.h"
-#  include "aether/mstream_buffers.h"
+#  include "aether/tiered_int_serializer.h"  // IWYU pragma: keep
 
 #  include "aether/ae_actions/ae_actions_tele.h"
 
@@ -93,10 +94,10 @@ std::optional<Telemetric> Telemetry::CollectTelemetry(
                        (11 + res.cpp.lib_version.size() + res.cpp.os.size() +
                         res.cpp.compiler.size());
   res.cpp.blob.reserve(blob_max_size);
-  auto vector_writer =
-      LimitVectorWriter<>{res.cpp.blob, res.cpp.blob.capacity()};
-  auto os = omstream{vector_writer};
-  os << *statistics_trap;
+
+  auto archive = seri::BinaryArchive{seri::LimitedVectorBuffer<>{res.cpp.blob}};
+  archive.Save(*statistics_trap);
+
   // TODO: should we reset stored statistics?
 
   return res;