fix(detail): show correct count of unresolved discussion threads#18
Merged
afewyards merged 1 commit intoMar 21, 2026
Merged
Conversation
anthraxx
force-pushed
the
fix/detail-wrong-unresolved-count
branch
from
b954a9e to
6a4f178
Compare
Currently in GitLab any comments that are not resolvable threads, system activity or similar events both, counted towards unresolved count in the details sidebar section as well as shown with an unresolved marker in the detail overview even though they aren't actionable. Resolve this by globally populating a `resolvable` property, which is assigned during fetching discussions. If an active thread's notes are unresolved, reflect that in the parent discussions dictionary.
anthraxx
force-pushed
the
fix/detail-wrong-unresolved-count
branch
from
6a4f178 to
bb4accf
Compare
Owner
|
thanks for your contributions!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in GitLab any comments that are not resolvable threads, system activity or similar events both, counted towards unresolved count in the details sidebar section as well as shown with an unresolved marker in the detail overview even though they aren't actionable.
Resolve this by globally populating a
resolvableproperty, which is assigned during fetching discussions. If an active thread's notes are unresolved, reflect that in the parent discussions dictionary.