Profil speaker - préférence micro#2204
Open
vgreb wants to merge 1 commit intoafup:masterfrom
Open
Conversation
Mopolo
reviewed
May 1, 2026
Contributor
Mopolo
left a comment
Mopolo
left a comment
There was a problem hiding this comment.
Je me demande si on ne devrait pas avoir un flag sur l'évent pour activer ou non cette nouvelle question. Comme le dîner speaker par exemple.
En AFUP Day c'est pas forcément utile de demander ça vu que le choix est pas forcément possible selon les salles.
vgreb
force-pushed
the
feature/speaker-mic-type
branch
from
5056a9b to
daa137d
Compare
vgreb
force-pushed
the
feature/speaker-mic-type
branch
from
daa137d to
3c461d5
Compare
Mopolo
reviewed
May 4, 2026
|
|
||
| private ?bool $accomodationEnabled = null; | ||
|
|
||
| private ?bool $micTypeEnabled = null; |
Contributor
There was a problem hiding this comment.
Vu que c'est DEFAULT 0 en base (ce qui me semble bien), pourquoi du nullable ici ?
Comment on lines
+9
to
+10
| case HEADSET = 'headset'; | ||
| case HANDHELD = 'handheld'; |
Contributor
There was a problem hiding this comment.
Suggested change
| case HEADSET = 'headset'; | |
| case HANDHELD = 'handheld'; | |
| case Headset = 'headset'; | |
| case Handheld = 'handheld'; |
Faudrait qu'on mette à jour le linter : https://www.php-fig.org/per/coding-style/#9-enumerations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajout des préférence de micro pour un speaker. Le nouveau bloc est situé entre ceux des informations de contact et du diner des speakers.
[EDIT]
J'ai rajouté la possibilité d'activer/désactiver le choix du micro selon l'évènement.
[/EDIT]
français
anglais
L'info est disponible dans le back-office