fix: replace bitwise OR with logical OR in gamepad connection check#529
Open
Xutzu11 wants to merge 1 commit into
Open
fix: replace bitwise OR with logical OR in gamepad connection check#529Xutzu11 wants to merge 1 commit into
Xutzu11 wants to merge 1 commit into
Conversation
In `onGamepadConnected()`, the condition used a bitwise OR (`|`) instead of a logical OR (`||`). This forces the evaluation of `hasEnoughInputs()` even when `mInputCount == 0` is already true. Switching to a logical OR enables short-circuit evaluation, preventing unnecessary method execution and potential side effects. Found via SonarQube analysis.
Author
|
@agateau @mirceamaierean I found a small bug on the project using a program verification tool, it would help me a lot if you could please review it and merge if it's all correct, thanks! |
mirceamaierean
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
onGamepadConnected(), the condition used a bitwise OR (|) instead of a logical OR (||). This forces the evaluation ofhasEnoughInputs()even whenmInputCount == 0is already true.Switching to a logical OR enables short-circuit evaluation, preventing unnecessary method execution and potential side effects. Found via SonarQube analysis.