perf: resolve session paths without full catalogue scans - #526
Open
Shujakuinkuraudo wants to merge 1 commit into
Open
perf: resolve session paths without full catalogue scans#526Shujakuinkuraudo wants to merge 1 commit into
Shujakuinkuraudo wants to merge 1 commit into
Conversation
Shujakuinkuraudo
force-pushed
the
shujk/resolve-session-paths
branch
from
August 19, 2026 16:04
b0bc22c to
55fabdc
Compare
Author
|
Follow-up hardening is now pushed: targeted and catalogue session paths are canonicalized and constrained to the physical default sessions root, including project-symlink escape coverage. The focused session-reader tests (20), changed-file ESLint, and TypeScript check pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relationship to existing work
Related to #513.
#516 independently implements the targeted saved-session lookup described by suggestion 1 in #513. This PR follows the same safety boundary — the filename is only a hint, the bounded header ID is proof, and misses retain the existing full-catalogue fallback — and additionally:
parentSessionpathThis PR deliberately does not change the initial
SessionManager.listAll()metadata scan. That is suggestion 2 in #513 and is better addressed in the Pi SDK than by duplicating session parsing in Pi Web.Validation
node --experimental-strip-types --test lib/session-reader.test.mjs app/api/sessions/runtime-route.test.mjsnpm test(591 passed)node_modules/.bin/tsc --noEmitnode_modules/.bin/eslint .npm run buildgit diff --checkAI assistance
OpenAI Codex was used to investigate the session-resolution path, implement the change, add regression coverage, and run the validation commands. The resulting diff was independently reviewed before submission.