Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix requests hanging after a malformed error response.
Connection._handle_response()removes the request from_pendingbefore reading the error payload. If a peer sends"error": ["malformed"], decoding raises before the future receives a result or exception. Disconnect cleanup can no longer find that future, so its caller keeps waiting while the other pending requests receiveConnectionError.Changes
Keep the future in
_pendinguntil its result or exception has been set. If response handling fails, the existing disconnect cleanup can then reject the affected request as well.Add regressions over real TCP streams for both automatic listening and
main_loop(), plus compatibility tests for valid responses, cancellation, duplicate responses, and shutdown.Testing
Local validation:
ConnectionErrorbefore callingclose().make check: passed.make test: 484 passed, 1 skipped. The skipped test is the optional Gemini integration test.