Hygiene: README claims match reality, cloud-first install block, drop dead package and empty deploy script - #62
Merged
Merged
Conversation
Empty source files (index.ts, reporting/dcrLastSeen.ts both 0 bytes), no description/license, name doesn't match directory. Never imported by any package.json dependency or .ts source outside its own tsconfig — only referenced via tsconfig project references/paths, which are dropped here too (root tsconfig.json, tsconfig.base.json, apps/gateway-server/tsconfig.json).
…ified via npm test)
This was referenced Sep 3, 2026
davidcrowe
marked this pull request as ready for review
September 3, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hygiene pass: README claims checked against reality, install block leads with
the cloud path per the current default, one dead package removed, one empty
script removed. No behavior change to any published package.
Changes (one per commit)
one-line
Add --local to run on-device with no account.note under thecloud curl command (the command itself already led with cloud, no
--local, so that part needed no change).pip install hermes-acp→pip install acp-hermes— thehermes-acp-plugin's
pyproject.tomldeclaresname = "acp-hermes";hermes-acpis only a compatibility console-script alias, not thedistribution name.
packages/explicabl-core(@gatewaystack/observability-core,v0.0.1): both source files were 0 bytes, no description/license, name
doesn't match its directory, and nothing imports it — confirmed via
grep -r "observability-core\|explicabl-core" --include=package.json --include=*.ts .outside its own tsconfig. Only referenced throughtsconfig project references/paths (root
tsconfig.json,tsconfig.base.json,apps/gateway-server/tsconfig.json), all removed.package-lock.jsonregenerated vianpm install.apps/gateway-server/deploy.sh(0 bytes, no README reference).the real 228 tests across 24 test files — counted with
find packages tests -name "*.test.ts" | wc -l(24) and confirmed withnpm test(228 passed, 24 files).examples/quickstart/README.md: sample output'sdetected:line updatedfrom
email, ssnto the realemail, ssn, icd_9— rannpm install --ignore-scripts && npm startinexamples/quickstartandpasted the actual output.
Test output (after all changes, from repo root)
Ghost-PR audit (for the coordinator — nothing closed by this PR)
Checked every non-dependabot open PR (#35–#49) by fetching each PR's head ref
and diffing file-by-file against current
origin/main. Evidence: commitc48a30d("Star-push OSS cleanup — one clean merge (bundles#44/#38/#45/#48/#49/#35/#37/#47) (#50)") explicitly lists 8 of them; #46's
content was independently confirmed byte-identical to main's current
policy.ts/scopes.ts(it duplicates #41, which reached main via commit176316d, PR #51). #36 is the one real gap — its fix is not on main.policy.ts/scopes.tsbyte-identical to main; duplicate of #41, merged as #51 (commit 176316d)middleware.tsdiff is non-empty vs main (the.split("/").filter(Boolean).pop()fix is missing); its test filemiddleware.scope.test.tsdoesn't exist on main at allDependabot (list only, per instructions):
Recommendation: close #35, #37, #38, #44–#49 as already-in-main (8 PRs); keep #36 open — it's a real, unmerged bypass fix.