test: update e2e sessions for readable ids - #452
Merged
Conversation
Contributor
🟢 No documentation gap found — high confidenceThe pull request only changes tests, lockfiles, generated metadata, or dependency metadata. This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- pass required readable names to local session-create E2E fixtures\n- replace legacy CLI Session selectors with valid readable IDs\n- align management E2E expectations with the shipped SESSION_NOT_FOUND contract\n\n## Root cause\n\nPR #443 made local session creation require a positional name and restricted public Session selectors to readable base-plus-suffix IDs. Four E2E fixtures still used the old nameless-create or legacy selector forms.\n\n## Verification\n\n- npm test: 460 files passed; 6,148 tests passed; 1 skipped\n- npm run typecheck: passed\n- reported and adjacent E2E: 3 files passed; 5 tests passed\n- management session-close E2E: 5 tests passed