refactor(examples): use load_ucp_signing_key_from_env in signed_ucp_merchant - #29
Merged
Conversation
…erchant Switches signed_ucp_merchant.py from inline env-loader logic (~50 lines: asyncio.Lock + cached future + JWK parsing + alg detection + ephemeral fallback) to the SDK helper. Behavior equivalent; case-insensitive env alg comparison via the helper is more lenient than the example's prior exact-match check. The example now exercises the same concurrent-safe caching the real consumers use, without duplicating the wiring. Net reduction: 43 lines (178 → 135). Bonus: fix two pre-existing ty errors in the selftest route — wrap JSONResponse.body in bytes() to satisfy the bytes-or-memoryview union that json.loads doesn't accept directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vvillait88
added a commit
that referenced
this pull request
May 14, 2026
## Summary Additive update to the README inventory table — documents the helpers that landed in PRs #22–#29 + the public-surface guard in #30. Pure docs, no code changes. ## What was added **`agentscore_commerce.identity` (package level)** row: - `load_ucp_signing_key_from_env` + `LoadUCPSigningKeyOptions` (env-driven UCP signing key loader; cached, alg-detected, sanitized errors) - `hash_operator_token` (sha256 hex of plaintext `opc_...` for merchants persisting `operator_token_id` to their own DB) **`agentscore_commerce.payment`** row: - `extract_payment_signer` now documents both the positional `x402_payment_header` path AND the `authorization_header=` MPP kwarg (`did:pkh:eip155` / `did:pkh:solana` source DIDs) - `detect_rail_from_headers` (returns `"x402"` / `"mpp"` / `None`) - `classify_orchestration_error` (companion to `classify_x402_settle_result` for orchestration-time exceptions) - `zero_amount_carve_out` (skip CDP/pympp upstream when settle_cents == 0) - `usd_to_atomic` (Decimal-based USD → atomic int, ROUND_HALF_UP) ## Test plan Docs-only; no code changes. Markdown renders cleanly in the existing table. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bonus
Fix two pre-existing ty errors in the selftest route (`JSONResponse.body` is typed as `bytes | memoryview[int]`; wrap in `bytes(...)` so `json.loads` accepts both branches). Pre-existing issue not caught by lefthook because `ty` only runs on `agentscore_commerce/`, not `examples/`.
Test plan
🤖 Generated with Claude Code