feat: autoclaim L1 -> L2#1644
Open
arnaubennassar wants to merge 20 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # multidownloader/evm_multidownloader_reorg.go # multidownloader/evm_multidownloader_reorg_test.go
…tic logs - config/config_test.go: move testify/urfave imports to end of non-stdlib group to satisfy gci two-group ordering (fixes CI lint failure) - config/default.go: set AutoClaim.L1ToL2Watchdog Enabled = true to match the assertion in TestLoadDefaultConfig (fixes unit test failure) - autoclaim/proof/preparer.go: add debug logs in selectL1InfoTreeIndex to surface whether the proof is blocked by l1InfoTree lag or gerSyncer lag - autoclaim/claimer/claimer.go: log info when proof not ready so E2E logs clearly show the pending state on each poll cycle Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rackedBlocks wipe reorgDetector.Start calls loadTrackedHeaders which replaces the in-memory trackedBlocks map entirely from DB. If l2gersync.New (which calls Subscribe internally) ran first, the subscription entry it added would be wiped by the subsequent loadTrackedHeaders call, causing every AddBlockToTrack to return "subscriber not subscribed" forever. The per-claimer l2gersync was stuck in a retry loop at the first GER injection block (block 24), never processing the GER that covered the bridge deposit, so GetFirstGERAfterL1InfoTreeIndex always returned ErrNotFound and the claim proof was never prepared. Fix: call reorgDetector.Start synchronously before l2gersync.New so that loadTrackedHeaders completes before Subscribe adds the entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The 3 SQL injection hotspots in autoclaim/storage/storage.go were marked SAFE on SonarCloud (all use parameterized ? placeholders, not user input). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add tests across 11 files covering uncovered nil-arg error paths, option closures, getter/accessor methods, disabled-state branches, and constructor validation to push SonarCloud new_coverage above the 80% quality gate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…overage Adds 7 targeted tests across sender and api packages to cover previously unreachable lines: default time.Now closure bodies, IsClaimed error propagation, pollResult Result() failure path, zero WaitPeriod fallback to s.pollPeriod, zero-MaxRetries target fallback to request.MaxRetries, and claimTxHash with nil Tx entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Changes Summary
autoclaimAggkit component for L1 -> L2 bridge claims. It discovers eligible exits froml1bridgesync, persists request/cursor/attempt state, prepares claim proofs withl1infotreesyncplus a per-claimerl2gersync, submitsclaimAsset/claimMessagetransactions throughEthTxManager, and tracks requests through confirmation or failure.allow-all,api-approve,no-message, andbasic-filter./autoclaim/v1for request listing, inspection, manual approval, and manual rejection, with generated Swagger docs.autoclaimcomponent, config loading/validation/defaults, docs, mocks, and the OP e2e environment./l1-info-tree-index: if a verified batch LER is missing from the local L2 exit tree, the lookup now avoids mixing L2 bridge-sync block numbers with L1 verified-batch block numbers and falls back to a bounded linear scan.[AutoClaim]config section and remains disabled by default.autoclaimcomponent selector and optional/autoclaim/v1API. Existing bridge service API paths are unchanged.📋 Config Updates
autoclaimcomponent and setting[AutoClaim].Enabled = true.[[AutoClaim.Claimers]]entry configures one EVM destination network with its own RPC URL, bridge address, policy, gas settings, retry settings, andEthTxManagerstorage/signing config.AutoClaim.StoragePath; each claimer also has an independentEthTxManager.StoragePathand isolated per-claimerl2gersync/ L2 reorg detector databases under the Auto Claim storage directory.✅ Testing
autoclaim/api,claimer,claimtx,config,policy,proof,runtime,sender,simulator,storage,types, andwatchdog.TestAutoClaimL1ToL2AllowAll,TestAutoClaimL1ToL2APIApprove, andTestAutoClaimL1ToL2BasicFilter.lint,test-unit, Go e2e, Docker image build, CodeQL, SonarCloud, and the configured multi/single-chain e2e workflows passing.Run govulncheckis currently failing.🐞 Issues
🔗 Related PRs
📝 Notes
origin_network:destination_network:deposit_count;origin_networkis the bridged token's origin network, not necessarily the chain where the bridge was initiated.l2gersync, which supports both legacy and sovereign L2 GER manager behavior.api-approvepolicy requires the Auto Claim API so operators can approve or reject requests inmanual-approval-requiredstatus.TestRemoveGER_NoProblematicClaims,TestRemoveGER_CategoryA,TestRemoveGER_CategoryB1,TestRemoveGER_CategoryB2, andTestGenerateInvalidGER. This is being worked on feat: migrate e2e tests from bats to go #1643GetFirstVerifiedBatchesAfterBlockwithGetLastRoot().BlockNum, which is an L2 bridge-sync block number even though the L1 info tree query expects an L1 block number. The new path only falls back ondb.ErrNotFound, keeps the original L1 verified-batch bounds, and skips missing LERs with a linear scan when binary search cannot safely continue.