Button, ButtonDropdown, Colour updates - #119
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DerekAgility
force-pushed
the
dlo/button-dropdown-updates
branch
from
August 20, 2026 18:53
5a8bc69 to
7b9cd00
Compare
jules-exel
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR.
Added a set height to
Button.tsx. Previously when we set the buttont's action type toalternativeorsecondary, we add a border around the button, which in turns causes these types of button to render 2px taller than theprimaryversion. This set height will make them uniform.Changed the style that the ButtonDropdown has
|
|
| Before | After |
|
New tailwind classes
Added some additional tailwind colour classes,
neutral-950,green-950,warning-950and a new class ofwarm.Also added
orange,redandamberwhich maps exactly towarning,errorandsecondary. Just keeping things consistent between Figma and our FE apps.