implemented requestWhenInUseAuthorization - #17
Open
spelcaster wants to merge 4 commits into
Open
spelcaster wants to merge 4 commits into
spelcaster wants to merge 4 commits into
Conversation
spelcaster
commented
Mar 13, 2018
spelcaster
commented
- The method uses Promises to handle the location source settings intent;
- Added a new react method called isLocationServiceEnabled to check if the gps service is enabled;
- Fixed some breaking changes in gradle settings and the module react package;
- Updated react-native dependency version;
- Use the react-native version from the user project;
- This updates the react-native to a version with new features that are going to be used later, such as Promises;
- The method requestWhenInUseAuthorization creates a promise that:
- will be resolved if the location service is already enabled, or;
- will be resolved onHostResume when the application is resumed after
the return from the location source settings intent;
- Added the method isLocationServiceEnabled to allow the user to check
the gps status from react;
- createJSModules does no longer exists in ReactPackage;
Author
|
This is for android only :| |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.