fix(verify): la page marche à l'URL sans slash (badge LinkedIn) - #72
Merged
Conversation
Le badge pointe vers /u/<handle> (sans slash). En relatif, la page chargeait /u/credential.jwt (404) -> badge affiché invalide. Calcule désormais tous les chemins (preuve, QR, téléchargements) depuis l'URL, robuste au slash final. Corrige aussi le serveur de démo (servait un dossier -> crash EISDIR). +4 tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug important trouvé en testant la démo dans un vrai navigateur.
Le bug
Le badge sur LinkedIn pointe vers
/u/<handle>(sans slash final). La page chargeait la preuve en relatif (./credential.jwt) → à cette URL ça résout/u/credential.jwt→ 404 → le badge s'affichait invalide. Pareil pour le QR et les téléchargements.Le fix
La page calcule tous ses chemins (preuve, QR, téléchargement) depuis l'URL (
memberBase), robuste au slash final :/u/handleet/u/handle/marchent tous deux, sur n'importe quel hébergeur.Corrige aussi le serveur de démo (
node run demo) qui plantait en servant un dossier.Vérifié
Testé en vrai dans un navigateur (Playwright) : la page rend « Badge valide » avec titulaire, dates, QR et téléchargements — à l'URL sans slash. 36 tests site verts (+4).
🤖 Generated with Claude Code