feat(vcs): add review-reply and review-apply skills - #522
Open
WaffoKom wants to merge 1 commit into
Open
Conversation
Reviewers currently have no AIDD skill to close the loop on a PR's review comments: 02-pull-request opens the request but nothing answers or fixes what comes back. - 05-review-reply replies to a reviewer's comments thread by thread, bots and Copilot excluded, drafts shown before anything posts. - 06-review-apply reads the same comments, applies one scoped fix each, verifies with a typecheck and aidd-dev:05-review, then explains what changed and why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ What
Adds two
aidd-vcsskills:05-review-replyreplies to a PR's human review comments thread by thread, and06-review-applyreads those same comments and applies the requested fixes.🤔 Why
02-pull-requestopens the request, but nothing inaidd-vcscloses the loop once review comments land — reviewers had no AIDD-native path to answer or act on feedback.🛠️ How
Both mirror
02-pull-request's router/action pattern:05-review-reply(collect → draft → post): fetches inline and general review comments viagh api, excluding Copilot and anyBot-typed user and threads already answered; reads the code around each comment to draft a reply that explains the why, not just "fixed"; shows every draft to the user and waits for confirmation before posting anything.06-review-apply(collect → apply → verify → explain): confirms the checked-out branch actually matches the PR's head before touching anything; applies one fix per comment, scoped to what was raised, evaluating a suggested fix rather than copy-pasting it; verifies with a typecheck andaidd-dev:05-reviewon the touched files; ends with a plain-language summary of what each comment asked and why the chosen fix.Deliberately out of scope for both: neither commits, pushes, or replies on the other's behalf —
06-review-applyexplicitly defers replying to05-review-reply.plugin.json, the pluginREADME.md, itsCATALOG.md, and the rootREADME.mdskill/plugin counts are updated to match (5 → 7 skillsforaidd-vcs,40 → 42overall).🧪 How to verify
node scripts/check-markdown-links.js --ignore cli/tests/fixtures --ignore cli/aidd_docs/tasks→0 broken./aidd-vcs:05-review-replyand/aidd-vcs:06-review-applyagainst any PR carrying review comments (including at least one bot/Copilot comment, to check the exclusion) and confirm: comments are fetched correctly, no reply/fix lands without an explicit confirmation step, and the06-review-applydiff stays scoped to what each comment asked.✅ I certify