-
Notifications
You must be signed in to change notification settings - Fork 2
Docs/style: Reformatting the Docs #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MithraGhlm
wants to merge
2
commits into
main
Choose a base branch
from
docs/reformat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,12 +55,12 @@ Start by creating a new application. | |
| 2. In the **Add components** section of the **Scene** tab, locate the **RealSense Camera** component. Click to add to | ||
| the graph. | ||
| 3. Next, connect the component to the start block. | ||
| <div style={{ display: "flex", justifyContent: "center" }}> | ||
| <video autoPlay loop muted playsInline style={{ maxWidth: "100%", borderRadius: "8px" }}> | ||
| <source src={realsenseNewApp} type="video/webm" /> | ||
| Creating a new RealSense Camera component. | ||
| </video> | ||
| </div> | ||
| <div style={{ display: "flex", justifyContent: "center" }}> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
| <video autoPlay loop muted playsInline style={{ maxWidth: "100%", borderRadius: "8px" }}> | ||
| <source src={realsenseNewApp} type="video/webm" /> | ||
| Creating a new RealSense Camera component. | ||
| </video> | ||
| </div> | ||
| 4. Press **Start** to start the application. | ||
| 5. To see the live camera feed, click on the gear icon on the bottom right and select **Launch RViz**. | ||
| 6. In RViz, select _Add > By topic > /realsense_camera/color_image_raw > Image_. This adds a panel that shows the live | ||
|
|
@@ -83,11 +83,11 @@ Click on the `RealSense Camera` component block to view and edit the available p | |
| Hovering over the exclamation marks next to the names shows a detailed description of the corresponding parameter. Let's | ||
| explain some of these here: | ||
|
|
||
| - `Color/Depth profile`: these refer to the resolution and frame rate of the color and depth images. Keep in mind that | ||
| - **Color/Depth profile**: these refer to the resolution and frame rate of the color and depth images. Keep in mind that | ||
| only specific pairs of values apply here. For more information check the camera's documentation. | ||
| - `Enable alignment`: flag that activates the alignment of the depth image to the corresponding color image. Enables the | ||
| **Aligned depth image** output, containing a depth image with the same size as the color. | ||
| - `Enable temporal filter`: flag that activates a temporal filter which improves depth data persistency by manipulating | ||
| - **Enable alignment**: flag that activates the alignment of the depth image to the corresponding color image. Enables the | ||
| `Aligned depth image` output, containing a depth image with the same size as the color. | ||
| - **Enable temporal filter**: flag that activates a temporal filter which improves depth data persistency by manipulating | ||
| per-pixel values based on previous frames. If activated, corresponding filter parameters can be directly defined in | ||
| the YAML editor to configure the filter behavior. To see what parameters can be defined, read the description by | ||
| hovering over the exclamation mark. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting might be off here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update with Prettier.
update: I checked visually and didn't notice what has changed there, except for bolding the numbers. So it would be nice if we could double check it together when your back in the office.