docs(054): make the connector-boundary design ready for implementation - #274
Merged
Merged
Conversation
…efault, scope fixes (WIP) Partial revision: ready set made lock-free, removed API listed, config parsing and transport.rs fate fixed, embedded write-ring default and size cap, thumbv6m resolved. Still to do: session client (§4.8), KNX (§4.9), migration table, CI gate details, §7/§8 updates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013u2xkHp6rrDP8cfrYErosd
Add §4.8 (pump_client over OutboundRoutes/InboundDispatch) and §4.9 (KNX without Channels), complete the §6 migration table and order, specify the CI gate and the MQTT round-trip allocation test (§5), add rejected alternatives 11-12, and mark the remaining open questions non-blocking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013u2xkHp6rrDP8cfrYErosd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checks design 054 (zero-allocation connector boundary) against the tree at
137ad2dand fills the gaps that would have blocked implementation. Doc-only change.Fixes and additions
VecDequeis taken inside route wakers. A producer on an EmbassyInterruptExecutor(049) that preempts the transport task while it holds the lock would deadlock a single core. Replaced with a bitmap ofAtomicU32s plusfutures_util::task::AtomicWaker(both already core dependencies), cleared before each poll and served round-robin. The fairness tests are unchanged, and §6 step 2 re-confirms the timings, which the prototype only measured for the FIFO.Serialized*types,RecvSerializedFuture, andcollect_outbound_routes/OutboundRoute(now crate-private). AddsSend/Syncbounds forOutboundRoutes/InboundDispatch, and keepsConnectorConfig/PublishError.pump_client(UDS, TCP, serial, WebSocket client) gets one outbound task overOutboundRoutesand takesInboundDispatch.Channels,TelegramChannel,CommandChannel,DEFAULT_QUEUEandNare removed, which is a second user-facing break (KnxConnector::new). The connection task dispatches and pulls directly.with_write_buffer. The new PUBLISH size cap (1,984 B) is documented as a behaviour change.thumbv6mis resolved as an unsupported target.qos/retainvalue that doesn't parse now fails the build instead of silently falling back to the default.make bench-gatetarget and CI job, plusaimdb-mqtt-connector/tests/alloc_round_trip.rsasserting embedded = 0 and native ≤ 11 allocations per round trip.connectors.rs, notsend_wrapper.rs; adds the WebSocket client, the embeddedsession.rs/tls.rs/manager.rs, examples and changelogs).Channels). The remaining open questions are marked non-blocking.Related Issue
Checklist
make check). (doc-only; not run)🤖 Generated with Claude Code
https://claude.ai/code/session_013u2xkHp6rrDP8cfrYErosd
Generated by Claude Code