Repository navigation
ci: gate b0_alloc_connector allocations (design 054 §5) - #275
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 1 of the 054 implementation plan. It makes
b0_alloc_connectora CI gate before any connector-boundary code changes, so every later stage is measured against a gate that already works.Changes
Makefile: newbench-gatetarget that runscargo bench --package aimdb-bench --bench b0_alloc_connector. It is added to.PHONYand to the help text..github/workflows/ci.yml: newBench Gatejob (same checkout and toolchain setup asmakefile-build) that runsmake bench-gate.comprehensive-checknow needs it.No bench code changes.
EXPECTEDand the committed baseline stay as they are.Verification
make bench-gatepasses locally, with all 8 rows at theirEXPECTEDvalues.inbound_routechanged from 0 to 1 inEXPECTED, the target fails ("inbound_route: expected 1, measured 0.00") and exits non-zero. The change was reverted.aimdb-benchtook about 1 minute locally.After merge
Bench Gateas a required check in branch protection.🤖 Generated with Claude Code