Repository navigation
perf(mqtt): move the inbound topic out of rumqttc's Publish instead of cloning - #276
Merged
Merged
Conversation
…f cloning Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 2 of the 054 implementation plan. It removes one allocation per inbound message on the native (
rumqttc) backend.Change
MqttEventLoopSource::nextowns thePublishit receives, so it now movespublish.topicout instead of cloning it. The payload is built frompublish.payloadfirst, and the debug log uses the movedString.The payload copy (
Arc::from(publish.payload.as_ref())) stays until the native backend moves toInboundDispatchlater in the 054 work.Verification
cargo test -p aimdb-mqtt-connector --features std: all pass.cargo test -p aimdb-mqtt-connector --no-default-features --features _test-backend-parity --test backend_parity: 8 passed.cargo clippy -p aimdb-mqtt-connector --features std --all-targets -- -D warningsandcargo fmt --check: clean.bench-gateshould not change, because the bench uses its own minimal source; CI checks it.🤖 Generated with Claude Code