Repository navigation
Merge main into feat/054-connector-boundary - #285
Merged
Merged
Conversation
Brings #284 (Maximum Packet Size in the embedded CONNECT). The only conflict was two constants added at the same place in session_loop.rs (PUBACK_ROOM here, MAX_INBOUND_PACKET from main); both are kept. The CONNECT block merged cleanly: ring.put plus the new property. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With main's Maximum Packet Size fix the fake broker withholds a push over the client's limit, so the 4,000-byte reconnect-loop proof no longer holds. a_retained_message_over_the_maximum_packet_size_is_withheld covers both the 3,000-byte and the 4,000-byte case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
maininto the 054 feature branch before stage 9 starts.mainadds only #284 (Maximum Packet Size in the embedded CONNECT, with its changelog entries). Please merge with a merge commit, not a squash, somain's commit stays in the feature branch's history.Commits
Merge main into feat/054-connector-boundary. The only conflict was two constants added at the same place insession_loop.rs:PUBACK_ROOM(from feat(mqtt): encode embedded packets into one bbqueue write ring (design 054 §4.7) #283) andMAX_INBOUND_PACKET(from fix(mqtt): advertise Maximum Packet Size in the embedded CONNECT #284). Both are kept. The CONNECT block merged cleanly and now hasTopicAliasMaximum(0)andMaximumPacketSize(3328), written throughring.put(&connect, 0).test(mqtt): drop the retained-message proofs now covered by tokio_broker.proof_a_4000_byte_retained_message_reconnects_forever(from feat(mqtt): encode embedded packets into one bbqueue write ring (design 054 §4.7) #283) wrong: it saw 1 connect, not ≥ 3.a_retained_message_over_the_maximum_packet_size_is_withheldcovers both the 3,000-byte and the 4,000-byte case, so both retained proofs are removed.proof_an_oversize_publish_is_dropped_silentlystays until stage 10.The test files and changelogs from
mainare unchanged againstmain.Verification
embedded-tlslib (includes #284's alignment test and the session-size test with the second CONNECT property)write_ring_proofssession_looptokio_brokerembassy_brokertls_sessiontls_brokerbackend_parity--features stdaimdb-mqtt-connectorclippy leg from the Makefile (host, test targets,thumbv7em) andcargo fmt --all --check: clean.embassy-mqtt-connector-demoandweather-station-gammabuild forthumbv8m.main-none-eabihf.feat/054-connector-boundary.🤖 Generated with Claude Code