Repository navigation
refactor(aimdb-sync): remove redundant try-set API - #288
Open
harunugurlu wants to merge 2 commits into
Open
harunugurlu wants to merge 2 commits into
harunugurlu wants to merge 2 commits into
Conversation
Collaborator
Author
|
@lxsaah Hey there, sorry for the delay on this one. Things have now calmed down and I will have time to work on the issues regularly. Would appreciate if you could review my work, thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SyncProducer::try_set,try_set_value, andSyncError::SetTimeoutTryProduceErrorfor future non-overwriting buffersVerification
cargo fmt --all -- --checkcargo clippy -p aimdb-sync --all-targets --all-features -- -D warningscargo test -p aimdb-sync --all-featurescargo test -p aimdb-sync --no-default-featuresRUSTDOCFLAGS="-D warnings" cargo doc -p aimdb-sync --all-features --no-depsmake checkcompleted all preceding checks but failed at the existingcodegen-driftstep on macOS because of a BSDsedregular-expression compatibility error: