Skip to content

refactor(aimdb-sync): remove redundant try-set API - #288

Open
harunugurlu wants to merge 2 commits into
aimdb-dev:mainfrom
harunugurlu:feat/issue-212-sync-api-cleanup
Open

harunugurlu wants to merge 2 commits into
aimdb-dev:mainfrom
harunugurlu:feat/issue-212-sync-api-cleanup

Conversation

@harunugurlu

Copy link
Copy Markdown
Collaborator

Summary

  • remove redundant SyncProducer::try_set, try_set_value, and SyncError::SetTimeout
  • keep core TryProduceError for future non-overwriting buffers
  • update producer, consumer, error, shutdown, fork, and buffer documentation
  • update tests, examples, and changelog for the current sync API

Verification

  • cargo fmt --all -- --check
  • cargo clippy -p aimdb-sync --all-targets --all-features -- -D warnings
  • cargo test -p aimdb-sync --all-features
  • cargo test -p aimdb-sync --no-default-features
  • RUSTDOCFLAGS="-D warnings" cargo doc -p aimdb-sync --all-features --no-deps

make check completed all preceding checks but failed at the existing codegen-drift step on macOS because of a BSD sed regular-expression compatibility error:

sed: RE error: invalid repetition count(s)
make: *** [codegen-drift] Error 1

@harunugurlu
harunugurlu requested a review from lxsaah as a code owner October 5, 2026 07:40
@harunugurlu

Copy link
Copy Markdown
Collaborator Author

@lxsaah Hey there, sorry for the delay on this one. Things have now calmed down and I will have time to work on the issues regularly. Would appreciate if you could review my work, thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant