Repository navigation
docs(design): make 056 aimdb join self-contained for a from-scratch implementation - #320
Merged
Merged
Conversation
…mplementation Drop the port of the planning-branch prototype: defects D1-D5 become requirements R1-R7, and all tests are listed as new. Specify what the previous revision left open: the whole response is written to the profile (unknown fields kept, nulls dropped), no redirects are followed, GitHub endpoints are overridable in tests only, discovery failure handling, a no-clobber profile write, exit-code plumbing in main, and the reqwest 0.12 pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WAwJGRt66jBy58M9hRtTr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revises design 056 (
aimdb joinCLI) so it no longer builds on theplanningbranch prototype, and can be implemented from scratch onmain.Removed: the "port
join.rsfromplanning" starting point, the D1–D5 defect table, the "kept fromplanning" tests, and theplanningcommit references.Restated: D1–D5 become plain requirements, R1–R7 (§1).
Newly specified (gaps a fresh implementation would otherwise have to decide):
nullis dropped, since TOML has none. Required fields are listed.https://base could redirect a 307/308 POST, token included, tohttp://.Debugoutput or in error messages.--appbehaviour after a 404.--force, and an fsync of the directory.CliError::exit_code()plumbed intomain, which currently always exits 1. Exit code 2 for "no usable auth kind" is now in the table.reqwestpinned to 0.12, since 0.13 renames the TLS features.tempfilemoves to a normal dependency.Docs only, no code changes.
Related Issue
Checklist
make check). (docs only)🤖 Generated with Claude Code
https://claude.ai/code/session_018WAwJGRt66jBy58M9hRtTr
Generated by Claude Code