Reduce to the declarative provider, as the upstream review asked - #4
Merged
Conversation
The upstream review asked for the API-key path only: "could you make it just use the api key one ... Declarative only - should be a much smaller change". Removes the browser sign-in flow and everything that reached it — the signup_aimlapi module with its loopback server and templates, the example, the config module wiring, and the setup-menu entry with its handler. The menu therefore returns to its original ordering as well. What remains is the declarative provider: the definition, its line in expose_declarative_providers!, and the docs row. Authentication is a plain AIMLAPI_API_KEY. The removed flow is kept on the pkce/agent-signin branch, where it stays available for this fork if it is ever wanted again. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The test also asserted where "AI/ML API" lands in the sorted provider list. That is not what a wiring test is for, it is brittle against any future provider whose display name sorts nearby, and asserting our own placement in someone else's suite is not ours to do. What is left mirrors test_gondola_provider_registry_wiring exactly: the provider resolves from the registry, and its name, default model and API key config are what the definition declares. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces this fork's
mainto what the upstream review asked for:Upstream PR aaif-goose/goose#11758 is open from this fork's
main, so merging this updates that PR in place.Effect on the upstream PR
What remains:
crates/goose-providers/src/declarative/definitions/aimlapi.jsoncrates/goose-providers/src/declarative.rsexpose_declarative_providers!crates/goose/src/providers/init.rsdocumentation/docs/getting-started/providers.mdAuthentication is a plain
AIMLAPI_API_KEY. The headers block follows the convention the other routers here already use —http-refererandx-titleidentifying goose — plus the two headers AI/ML API reads to attribute traffic.Removed
The browser sign-in flow and everything that reached it: the
signup_aimlapimodule with its loopback server and HTML templates, the example, the config module wiring, and the setup-menu entry with its handler. The setup menu therefore returns to its original ordering and labels.The flow is not lost — it is kept on
pkce/agent-signin(e55acdbd), where it stays available to this fork.Also trimmed
The registry wiring test additionally asserted where
AI/ML APIlands in the sorted provider list. That is not what a wiring test is for, it is brittle against any future provider sorting nearby, and asserting our own placement in someone else's suite is not ours to do. What is left mirrorstest_gondola_provider_registry_wiringexactly.Verification
cargo build -p goose-cli— succeeds. (--no-default-featuresminuslocal-inference, which needs libclang for bindgen and is unrelated to this change.)cargo test -p goose --lib providers::init— 10 passed, includingtest_aimlapi_provider_registry_wiring.cargo fmt --check— clean.goose runon this build answers onaimlapi openai/gpt-5-5with onlyAIMLAPI_API_KEYset — no sign-in flow involved.