Add fuzzing to CI - #12887
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12887 +/- ##
==========================================
- Coverage 98.99% 98.25% -0.75%
==========================================
Files 132 131 -1
Lines 49454 49702 +248
Branches 2572 2619 +47
==========================================
- Hits 48959 48835 -124
- Misses 371 733 +362
- Partials 124 134 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Merging this PR will not alter performance
Comparing Footnotes
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
|
@DavidKorczynski Could you check over this PR and confirm how to complete the integration with oss-fuzz repo? |
|
Tested the fuzz branch locally with the OSS-Fuzz base-builder-python image: two bugs in fuzzers/multipart.py crash the fuzzer (StreamReader never imported -> NameError; HeadersDictProxy passed a plain dict instead of CIMultiDict -> AttributeError: 'dict' object has no attribute 'getall'). Full details in my comment on oss-fuzz issue #15791. Fix PR targeting this branch is coming shortly. |
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported undefined Reviews (4): Last reviewed commit: "Update http_parser.py" | Re-trigger Greptile |
|
Looks like this needs to be merged with fuzzers only first, so oss-fuzz can update their end, then we can add the CI runs after that. |
| from aiohttp.helpers import HeadersDictProxy | ||
|
|
||
|
|
||
| class FuzzStream(StreamReader): |
From an OSS-Fuzz perspective this looks reasonable. It may be easier to first fix the broken OSS-Fuzz builds -- you can see logs here https://oss-fuzz-build-logs.storage.googleapis.com/index.html#aiohttp If you'd like, I'm happy to push a PR on the OSS-Fuzz side to fix things, which may resolve the CI failures here. Let me know if you'd like me to do that. Once that is done, I suspect it will be easier to get this PR over the line and the CIFuzz signals green. Did you confirm this work locally with OSS-Fuzz's |
Thanks, I iterated a little with someone's bot on google/oss-fuzz#15990 Do you think it'll be possible to get this atheris PR merged and released soon? |
No description provided.