Skip to content

Improve Link regex performance - #13306

Draft
Dreamsorcerer wants to merge 4 commits into
masterfrom
Dreamsorcerer-patch-2
Draft

Improve Link regex performance#13306
Dreamsorcerer wants to merge 4 commits into
masterfrom
Dreamsorcerer-patch-2

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Member

Cases to add to test:

'\n\t'*13367 + '\x00'
'\x00="' + '\t'*14436 + '\x00'

@Dreamsorcerer Dreamsorcerer added backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot labels Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.98%. Comparing base (537125a) to head (0c7994f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13306   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         132      132           
  Lines       49055    49055           
  Branches     2552     2552           
=======================================
  Hits        48558    48558           
  Misses        373      373           
  Partials      124      124           
Flag Coverage Δ
Autobahn 22.13% <0.00%> (ø)
CI-GHA 98.90% <100.00%> (ø)
OS-Linux 98.67% <100.00%> (ø)
OS-Windows 97.02% <100.00%> (-0.01%) ⬇️
OS-macOS 97.93% <100.00%> (+<0.01%) ⬆️
Py-3.10 98.12% <100.00%> (-0.01%) ⬇️
Py-3.11 98.37% <100.00%> (ø)
Py-3.12 98.46% <100.00%> (ø)
Py-3.13 98.44% <100.00%> (-0.01%) ⬇️
Py-3.14 98.46% <100.00%> (ø)
Py-3.14t 97.56% <100.00%> (+<0.01%) ⬆️
Py-pypy-3.11 97.40% <100.00%> (+<0.01%) ⬆️
VM-macos 97.93% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.67% <100.00%> (ø)
VM-windows 97.02% <100.00%> (-0.01%) ⬇️
cython-coverage 37.97% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer

Copy link
Copy Markdown
Member Author

Potential fix for second one:
r"^\s*(\S+)\s*=\s*(?:(['\"])(.*?)(\2)|(\S*))\s*$"

@codspeed-hq

codspeed-hq Bot commented Aug 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 84 untouched benchmarks
⏩ 83 skipped benchmarks1


Comparing Dreamsorcerer-patch-2 (0c7994f) with master (537125a)

Open in CodSpeed

Footnotes

  1. 83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread aiohttp/client_reqrep.py Outdated
Comment thread aiohttp/client_reqrep.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant