Build the binary on top of the lib crate / Address remaining warnings - #17
Merged
Merged
Conversation
main.rs re-declared every module instead of using the pallograph lib, so each module compiled twice, unit tests ran twice, and the bin reported dead code for items only the lib used. Import through the lib instead, exposing config, load, and repl publicly for the bin. Allow clippy::type_complexity for now (TODO to revisit). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apply clippy --fix, convert manual prefix slicing to strip_prefix, and remove unused items: CompiledProgram.arena, Step::Scan.n_cols, Step::Insert.head_rel, and assert_rbac_axioms_from_snapshot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.rs re-declared every module instead of using the pallograph lib,
so each module compiled twice, unit tests ran twice, and the bin
reported dead code for items only the lib used. Import through the
lib instead, exposing config, load, and repl publicly for the bin.
Allow clippy::type_complexity for now (TODO to revisit)."