feat(binding-llm): module scaffold with Incubating LlmBindingInfo - #2552
Open
jfallows wants to merge 2 commits into
Open
feat(binding-llm): module scaffold with Incubating LlmBindingInfo#2552jfallows wants to merge 2 commits into
jfallows wants to merge 2 commits into
Conversation
Scaffold incubator/binding-llm.spec per AGENTS.md conventions and define LlmBeginEx, LlmDataEx, and the LlmFlushEx union, modelled on binding-mcp.spec's idl. LlmBeginEx carries dialect only; model routing is deferred. LlmDataEx has no fields: content flows through the DATA frame's own payload octets and INIT/FIN through its existing flags, so nothing survives in the extension once block identity moves to the FLUSH plane. LlmFlushEx is a 7-case union covering message start, block start/end, finish, usage, keepalive, and an opaque native/raw case for re-encoding events a same-dialect route doesn't recognize. Fixes #2476 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuZoMsETwEczJx3cbkb8EJ
Scaffolds incubator/binding-llm and incubator/binding-llm.conf, modelled on binding-mcp's SERVER/CLIENT BindingContext structure. LlmBindingInfo is annotated @Incubating so type: llm config loading is gated behind ZILLA_INCUBATOR_ENABLED via FeatureFilter, matching the AmqpBindingInfo/ PgsqlBindingInfo/RisingwaveBindingInfo precedent. Fixes #2477 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0142buJWS7C89AKr9uDJtSy4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scaffolds
incubator/binding-llm(runtime) andincubator/binding-llm.conf, modelled onbinding-mcp's SERVER/CLIENTBindingContextstructure, per the incubator layout used bybinding-pgsql/binding-risingwave(spec/conf/runtime co-located underincubator/, Aklivity Community License).incubator/binding-llm:LlmBinding,LlmBindingContext(SERVER/CLIENT-keyed dispatch map; no stream factories wired up yet),LlmBindingFactorySpi,LlmConfiguration.incubator/binding-llm.conf:LlmBindingInfo implements BindingInfo,TYPE = "llm", annotated@io.aklivity.zilla.runtime.common.feature.Incubating— the mechanismFeatureFilterreads to gatetype: llmrecognition behindZILLA_INCUBATOR_ENABLED, matching theAmqpBindingInfo/PgsqlBindingInfo/RisingwaveBindingInfoprecedent — plus a schema patch addingtype: llmwithkind: client|server.incubator/pom.xml.This branch is built on top of
binding-llm.spec(llm.idl) from #2505 so it can carry that work forward as a baseline; it will be rebased ontodeveloponce #2505 merges.Verified
./mvnw clean install -pl incubator/binding-llm.conf,incubator/binding-llmpasses end-to-end: checkstyle, license headers, NOTICE, and all unit tests pass with full jacoco coverage. WithZILLA_INCUBATOR_ENABLEDunset,type: llmfails config loading as unrecognized; with it set,type: llmis recognized — reusing the sameFeatureFilter/@Incubatinggating already proven bybinding-pgsql/binding-risingwave.Fixes #2477
🤖 Generated with Claude Code
https://claude.ai/code/session_0142buJWS7C89AKr9uDJtSy4
Generated by Claude Code