fix(drawbox): start freehand strokes at the exact press point - #131
Merged
Conversation
PEN/shape/eraser drags were driven by detectDragGestures, whose onDragStart only fires after the pointer crosses the ~8dp system touch slop and reports the slop-crossing position — so strokes began offset from and slightly after the finger-down point. Replace it with a custom awaitEachGesture loop that begins drawing-mode gestures on the first movement with zero touch slop, seeded at the true press point, while keeping the system slop for SELECT/PAN so a click isn't misread as a drag. Starting on first move (not on down) keeps the tap handler as the sole handler for taps and avoids stray dots when a pinch begins before any drag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEN/shape/eraser drags were driven by detectDragGestures, whose onDragStart only fires after the pointer crosses the ~8dp system touch slop and reports the slop-crossing position — so strokes began offset from and slightly after the finger-down point.
Replace it with a custom awaitEachGesture loop that begins drawing-mode gestures on the first movement with zero touch slop, seeded at the true press point, while keeping the system slop for SELECT/PAN so a click isn't misread as a drag. Starting on first move (not on down) keeps the tap handler as the sole handler for taps and avoids stray dots when a pinch begins before any drag.
Summary
Type of change
Affected targets
Public API impact
2.xfrozen surface — link to RFC or discussion:Testing
Checks
./gradlew :DrawBox:spotlessCheckpasses./gradlew :DrawBox:jvmTestpasses./gradlew :DrawBox:dokkaGenerateHtmlpassesScreenshots / recording
Linked issues