ci: run JVM/JS/WASM/iOS tests on PRs, add end-to-end draw tests - #133
Merged
Conversation
Previously CI only ran JVM tests and compile-checked WASM/iOS. The JS target was not exercised at all and WASM/iOS were never run. Now every published target runs the shared commonTest suite: - JVM, JS (browser), WASM (browser) on ubuntu - iOS on the simulator (macos runner), upgraded from compile-only JS/WASM tests run under Karma against headless Chrome (setup-chrome + CHROME_BIN). Both :DrawBox and :drawbox-ui are covered. Also adds two end-to-end tests driving DrawBoxController through a full pen gesture, so a green run proves a user can actually draw a stroke and undo it on each platform — not merely that the code compiles.
The JS/WASM Karma browser tests failed on the Linux CI runner with a
ZygoteHostImpl fatal ("ChromeHeadless cannot start"): Chrome's setuid
sandbox can't initialize in that environment. Add a karma.config.d
launcher for both modules that runs headless Chrome with --no-sandbox.
Appended after the plugin's default config, so the browsers override
wins. Harmless on local macOS runs (verified).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously CI only ran JVM tests and compile-checked WASM/iOS. The JS target was not exercised at all and WASM/iOS were never run. Now every published target runs the shared commonTest suite:
JS/WASM tests run under Karma against headless Chrome (setup-chrome + CHROME_BIN). Both :DrawBox and :drawbox-ui are covered.
Also adds two end-to-end tests driving DrawBoxController through a full pen gesture, so a green run proves a user can actually draw a stroke and undo it on each platform — not merely that the code compiles.
Summary
Type of change
Affected targets
Public API impact
2.xfrozen surface — link to RFC or discussion:Testing
Checks
./gradlew :DrawBox:spotlessCheckpasses./gradlew :DrawBox:jvmTestpasses./gradlew :DrawBox:dokkaGenerateHtmlpassesScreenshots / recording
Linked issues