Skip to content

Feat/api cleanup #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acegoal07 merged 4 commits into from
Jul 9, 2026
Merged

Feat/api cleanup #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
114fb99
Update settings.json
acegoal07 Jul 8, 2026
eedb607
Merge branch 'main' into feat/api-cleanup
acegoal07 Jul 8, 2026
2a4f7a2
Merge branch 'main' into feat/api-cleanup
acegoal07 Jul 8, 2026
60478b5
Fixes api + tweaked overview
acegoal07 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"cSpell.words": [
"sanitised",
"squeue"
]
"cSpell.words": [
"teampool"
]
}
4 changes: 2 additions & 2 deletions backend/endpoints/report/controller/getDailyOverviewReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ module.exports = (db) => {
const { date } = req.query || {};

// Check date
if (typeof date !== 'number') {
if (typeof date !== 'string') {
return res
.status(400)
.json({ success: false, error: 'The data provided is not a number' });
.json({ success: false, error: 'The date provided is not a string' });
}

// Get people
Expand Down
64 changes: 32 additions & 32 deletions frontend/app/components/Overview.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,39 +199,39 @@ export default function Overview() {
</div>

{/* Results */}
<div className="mt-5 space-y-3 border-t border-white/10 pt-4">
{console.log('Component rendered')}

{element.results.map((result) => (
<div
key={`${result.instructionId}`}
className="rounded-lg border border-white/10 bg-slate-900/40 p-3 transition"
>
<div className="mb-2 flex items-start justify-between gap-3">
<h3 className="text-sm font-semibold text-white sm:text-base">
{result.title}
</h3>

<span
className={`shrink-0 rounded-full border px-2.5 py-1 text-[10px] font-semibold uppercase tracking-wide ${
result.passed
? 'border-green-400/30 bg-green-500/20 text-green-300'
: 'border-red-400/30 bg-red-500/20 text-red-300'
}`}
>
{result.passed ? 'Passed' : 'Failed'}
</span>
{element.results.length > 0 && (
<div className="mt-5 space-y-3 border-t border-white/10 pt-4">
{element.results.map((result) => (
<div
key={`${result.instructionId}`}
className="rounded-lg border border-white/10 bg-slate-900/40 p-3 transition"
>
<div className="mb-2 flex items-start justify-between gap-3">
<h3 className="text-sm font-semibold text-white sm:text-base">
{result.title}
</h3>

<span
className={`shrink-0 rounded-full border px-2.5 py-1 text-[10px] font-semibold uppercase tracking-wide ${
result.passed
? 'border-green-400/30 bg-green-500/20 text-green-300'
: 'border-red-400/30 bg-red-500/20 text-red-300'
}`}
>
{result.passed ? 'Passed' : 'Failed'}
</span>
</div>

<p className="block text-xs uppercase text-slate-400">
Notes:
</p>
<p className="break-words text-sm leading-relaxed text-slate-300">
{result.note}
</p>
</div>

<p className="block text-xs uppercase text-slate-400">
Notes:
</p>
<p className="break-words text-sm leading-relaxed text-slate-300">
{result.note}
</p>
</div>
))}
</div>
))}
</div>
)}
</div>
))}
</div>
Expand Down
Loading