Skip to content

ci: make docs agent review guard requireable#1271

Merged
SahilAujla merged 2 commits intomainfrom
sa/no-originator-self-approval-required-check
Apr 27, 2026
Merged

ci: make docs agent review guard requireable#1271
SahilAujla merged 2 commits intomainfrom
sa/no-originator-self-approval-required-check

Conversation

@SahilAujla
Copy link
Copy Markdown
Collaborator

Summary

  • Makes the docs agent review guard produce a check result for every submitted review so it can be required in branch protection.
  • Keeps human-authored PRs passing without enforcement.
  • For docs-agent PRs, fails the required check when current active approvals are only from the trusted requester set.

Behavior

  • Human-authored PR approval: pass.
  • Docs-agent PR with non-requester approval: pass.
  • Docs-agent PR with requester approval plus non-requester approval: dismiss requester approval and pass.
  • Docs-agent PR with only requester approval: dismiss requester approval and fail.
  • Docs-agent PR without trusted requester attribution: keep the existing missing-attribution behavior.

@SahilAujla SahilAujla requested a review from a team as a code owner April 27, 2026 17:48
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

🔗 Preview Mode

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Apr 27, 2026, 8:08 PM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

🔍 Link Check

Status: ⏭️ Skipped (no content changes)

View workflow run

dslovinsky

This comment was marked as duplicate.

@dslovinsky dslovinsky dismissed their stale review April 27, 2026 19:52

Submitted in error — meant to leave as pending draft. Will re-post.

Comment thread .github/workflows/no-originator-self-approval.yml
Comment thread .github/workflows/no-originator-self-approval.yml
Comment thread .github/workflows/no-originator-self-approval.yml Outdated
Comment thread .github/workflows/no-originator-self-approval.yml
@SahilAujla
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SahilAujla SahilAujla merged commit 6e74517 into main Apr 27, 2026
17 checks passed
@SahilAujla SahilAujla deleted the sa/no-originator-self-approval-required-check branch April 27, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants