Skip to content

Update to liblzma and make kmer-counters the defaults - #73

Open
lrobidou wants to merge 3 commits into
algbio:mainfrom
lrobidou:main
Open

Update to liblzma and make kmer-counters the defaults#73
lrobidou wants to merge 3 commits into
algbio:mainfrom
lrobidou:main

Conversation

@lrobidou

Copy link
Copy Markdown
Contributor

Hello,

The xz2 crate is unmaintained. I propose replacing it with https://github.com/portable-network-archive/liblzma-rs .

I also propose making the kmer-counters feature part of the default.

Don't hesitate to ask for 2 separate PR if needed.

Best,
Lucas.

@lrobidou

Copy link
Copy Markdown
Contributor Author

This would solve #67 .

@Guilucand

Copy link
Copy Markdown
Collaborator

Hi @lrobidou, thanks for the pull request! I integrated the liblzma library change in the main branch.
For the kmer-counters default I still have to think about it if it's the best solution, as enabling it by default adds some overhead even if counters are not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants