[fix]: make mongoshake-stat compatible with Python 2 and Python 3#983
Open
hyeonghwa wants to merge 1 commit into
Open
[fix]: make mongoshake-stat compatible with Python 2 and Python 3#983hyeonghwa wants to merge 1 commit into
hyeonghwa wants to merge 1 commit into
Conversation
- Replace `urllib2` with try/except import for Python 2/3 compatibility - Add `from __future__ import print_function` for print() compatibility - Replace `unicode` type check with `str` - Replace `dict.has_key()` with `in` operator - Wrap `dict.keys()` with `list()` for sortability in Python 3
|
hyeonghwa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urllib2with try/except import for Python 2/3 compatibilityfrom __future__ import print_functionfor print() compatibilityunicodetype check withstrdict.has_key()withinoperatordict.keys()withlist()for sortability in Python 3Test plan
python2 ./mongoshake-stat --port=9100and verify no SyntaxErrorpython3 ./mongoshake-stat --port=9100and verify no SyntaxError