Allow integrations to overwrite stop#663
Merged
Merged
Conversation
delatrie
force-pushed
the
defer-stop-callbacks
branch
from
abed73b to
951a6eb
Compare
epszaw
approved these changes
Jun 23, 2026
delatrie
force-pushed
the
defer-stop-callbacks
branch
from
951a6eb to
23165f5
Compare
delatrie
force-pushed
the
defer-stop-callbacks
branch
from
23165f5 to
b04ea11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The PR changes
AllureLifecycle.StopTestCase,AllureLifecycle.StopFixture, andAllureLifecycle.StopStepto call their callbacks after they updatestageandstop, not before. This allows integrations to set the timings based on their own sources of truth rather than relying onDateTimeOffset.Now, which may give incorrect results in some message-based architectures.Additionally, these functions now check whether the
stoptimestamp has already been set before setting it toDateTimeOffset.Now, so integrations that receive the timings separately from test stop events don't have to store them.Checklist