Skip to content

glob: match against the full path, not just the basename #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alpibrupa merged 1 commit into from
Sep 3, 2026
Merged

glob: match against the full path, not just the basename #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/tools/standard/glob.lex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,20 @@ fn params() -> s.ModelSchema {
{ title: "GlobArgs", description: "Find files matching a pattern", fields: [s.required_str("pattern", []), s.optional(s.required_str("directory", []))] }
}

# `-name` matches only a file's basename, so any pattern containing "/" —
# "**/*.lex", "src/*", "lex/specs/**" — can never match anything: find
# silently reports no results instead of erroring, so the caller has no
# signal anything went wrong. `-path` matches against the full path find is
# already walking (BSD and GNU find both apply it without FNM_PATHNAME, so
# "*" matches "/" too), which handles the recursive-glob and nested-prefix
# forms models actually send while still behaving identically to `-name`
# for a plain slash-free pattern like "*.lex".
fn execute(args :: jv.Json) -> [net, io, proc] Result[jv.Json, e.Errors] {
match util.field_str(args, "pattern") {
None => Err(e.single("", "missing_field", "pattern is required")),
Some(pattern) => {
let dir := util.field_str_or(args, "directory", ".")
match proc.run("find", [dir, "-name", pattern, "-type", "f"]) {
match proc.run("find", [dir, "-path", pattern, "-type", "f"]) {
Err(msg) => Err(e.single("", "proc_error", msg)),
Ok(out) => {
let result := if str.is_empty(out.stdout) {
Expand Down
Loading