fix(mcp): consolidate and recall memory on every request - #112
Merged
Conversation
make_handler ran ag.run_loop directly on a raw AgentLoop, never constructing a session.lex Session the way ACP/TUI/graph.lex do — so consolidate.run() never ran for MCP, and a remember tool call made over MCP wrote a candidate that stayed an unconsolidated candidate forever, regardless of provider. Brains are built once in main(), before any candidate exists, so a per-request refresh is the only place MCP can pick up memory at all: each call now consolidates pending candidates under a fresh synthetic id (MCP has no client-tracked session to attribute them to) and re-recalls before running the loop, via sess.with_memory — same mechanism session.lex uses. Recall goes through pmem.open() + recall_for_prompt() rather than the higher-level recall_context(), since the latter's fs.exists guard needs fs_walk, an effect Skill.handle's fixed row (lex-agent/src/server.lex) does not carry; open() already creates the db lazily so the guard isn't needed here. Fixes #109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #109
Test plan