Fix controller-relative ECR paths on Windows - #1402
Merged
Merged
Conversation
crimson-knight
marked this pull request as ready for review
August 11, 2026 12:20
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
crystal spec spec/amber/controller/render_spec.cr: 7 examples, 0 failurescrystal spec: 2,321 examples, 0 failuresRelease boundary
Windows is not a beta release gate. The candidate fix is proven in CI, but Amber 2.0.0-beta.2 does not contain it; released Windows support should be claimed only after a later framework beta ships and passes the same generated-app job.