Skip to content

Parse browser form data in schema controllers - #1404

Merged
crimson-knight merged 3 commits into
amberframework:v2-devfrom
crimson-knight:agent/v2-default-web-persistence
Aug 11, 2026
Merged

Parse browser form data in schema controllers#1404
crimson-knight merged 3 commits into
amberframework:v2-devfrom
crimson-knight:agent/v2-default-web-persistence

Conversation

@crimson-knight

Copy link
Copy Markdown
Member

Summary

  • route schema request parsing through Amber's registered content-type parsers
  • parse the body before route matching can consume browser form data while checking _method
  • cover merged URL-encoded browser form fields alongside query data

This fixes the framework side of Amber V2's database-backed default web scaffold. The generated HTML form uses application/x-www-form-urlencoded; before this change it rendered correctly but its submitted fields never reached the schema.

Validation

  • controller/schema form integration: 13 examples, 0 failures
  • Crystal formatting: changed source and spec clean

@crimson-knight
crimson-knight marked this pull request as ready for review August 11, 2026 20:30
@crimson-knight
crimson-knight merged commit 400d8af into amberframework:v2-dev Aug 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant