feat: separate auto-export settings and redesign settings window#54
Conversation
- Extract UI components (FrameSettingsPanel, MetadataSettingsPanel, ToggleInput) - Add "Save as Auto-Export Default" button to main view, removing automatic background saving - Redesign Settings window with a tabbed sidebar and increase initial size to 800x600 - Add EXIF override capability for Digital profiles with `OverrideExif` toggle - Improve settings type safety, fix CSS variable typos, and clean up inline styles - Add toast notification for saving settings
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughフロントエンドでEXIF型・可視性ヘルパーと再利用可能UIを導入し、設定ウィンドウをパネル化してSettings保存フローと「Save as Auto-Export Default」を追加。バックエンドのSettings構造もEXIF項目とOverrideExifで拡張しました。 Changesメタデータ設定UIと自動書き出しデフォルト保存
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/MetadataSettingsPanel.tsx`:
- Around line 50-65: The JSX in MetadataSettingsPanel uses many inline style
objects for the wrapper div, label, input and small elements (condition under
profile==='digital' && isDefaultMode && setOverrideExif and props
overrideExif/setOverrideExif); extract those inline styles into semantic CSS
classes (e.g., .metadata-panel, .metadata-label, .metadata-checkbox,
.metadata-help), add a corresponding .css or .module.css file, import it into
MetadataSettingsPanel.tsx, replace the style={...} props with className
attributes, and remove the inline style objects to keep markup clean and
reusable.
In `@frontend/src/SettingsWindow.tsx`:
- Line 10: SettingsWindow.tsx defines TOAST_DURATION_MS = 2500 while App.tsx
uses TOAST_DURATION_MS = 3000; pick a single duration and make both modules use
that same value (either by updating one constant to match the other or by
extracting a shared exported constant from a central module and importing it
into both SettingsWindow.tsx and App.tsx) so TOAST_DURATION_MS is consistent
across the app.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b958e769-8b43-48b3-9382-cd69a7aa8d4b
📒 Files selected for processing (9)
app.gofrontend/src/App.cssfrontend/src/App.tsxfrontend/src/SettingsWindow.tsxfrontend/src/components/FrameSettingsPanel.tsxfrontend/src/components/MetadataSettingsPanel.tsxfrontend/src/components/ToggleInput.tsxfrontend/src/types.tssettings.go
OverrideExiftoggleresolved #31