refactor(tui): simplify TUI layer (-299 net lines)

[kelsonpw]

Summary

Seven low-risk simplifications to src/ui/tui/ with no behavior changes. 380 lines deleted, 81 added — net -299 lines, 4469 tests pass (unchanged from baseline).

Commits (each reviewable independently)

1. Extract KeyHintInline primitive for [K] label rows — replaces 8 verbose six-line <Box><Text>[</Text><Text bold>K</Text><Text>] label</Text></Box> blocks in AuthScreen, DataSetupScreen, DataIngestionCheckScreen with a single one-line component. Refactors KeyHintBar to share the same primitive.
2. Share EMPTY_HINTS between hint hooks — useEscapeBack had its own private copy of the frozen empty array; now imports from useScreenHints. Also hoists SignupFullNameScreen's useMemo (empty deps) to a module-level frozen const, matching the existing pattern in RegionSelectScreen / IntroScreen.
3. Lookup tables for JourneyStepper glyph/color — replaces the nested ternary chains with two Record<StepState, ...> lookups. The doneSuccess state-overlay stays explicit.
4. Delete dead primitives — CardLayout and SplitView were exported via primitives/index.ts but never imported anywhere; same for the HAlign / VAlign enums in styles.ts.
5. Delete dead AmplitudeLogo / AnimatedAmplitudeLogo — replaced by DiscoveryFeed in PR feat(tui): polish Welcome screen — tighter copy, inline workspace picks, smaller logo on returning runs #677; only references left are historical comments. 151 lines of gradient/wave animation math.
6. Pre-build hint constants in SignupEmailScreen — the per-render useMemo switched on a single boolean; replaced with two module-level frozen hint arrays + a ternary.
7. Merge duplicate primitives import in ConsoleView — two separate import { X } from '../primitives/index.js' lines collapsed into one.

Patterns identified but deferred

• Signup-flow signupRequiredFields.includes('terms_acceptance') / 'full_name' checks repeat in flows.ts — load-bearing flow predicates with subtle correctness guarantees around back-nav walls and isWall predicates. Worth a dedicated refactor with tests targeting those specific invariants; not a drop-in win.
• Dynamic import('../../../lib/registry.js') in IntroScreen's FrameworkPicker — appears twice, but both are gated on user action (entering the picker / picking a framework) and serve startup-cost goals. Merging would require a module-level cache.
• isPickerAction typeguard in AuthScreen — only used twice in the same file; not worth abstracting further.
• Duplicate /help registration in console-commands.ts — looks like a regression from PR feat(tui): register /help slash command and Tab autocomplete in palette #769 but removing the dupe could change which descriptor COMMANDS.find() returns; better handled as a discrete bug-fix PR with its own test.

Tests

• Before: 4469 passed (297 files)
• After: 4469 passed (297 files)
• Snapshots regenerated: 0 (rendered output is byte-identical for every replaced block — KeyHintInline produces the same <Box><Text>[</Text>…<Text>]…</Text></Box> tree)

Verification

• pnpm tsc --noEmit — green
• pnpm lint — green
• pnpm test — green, same count
• src/utils/wizard-abort.ts — untouched
• src/lib/ — untouched (sibling agent territory)

Test plan

• pnpm tsc --noEmit passes
• pnpm lint passes (prettier + eslint)
• pnpm test — 4469 tests pass
• pnpm exec vitest run --pool=forks --maxWorkers=1 src/ui/tui/ — 1019 tests pass

---

Note

Low Risk
Low risk refactor limited to TUI rendering and imports, mainly deleting unused components and replacing repetitive UI fragments with shared helpers. Primary risk is minor visual regressions in key-hint/stepper presentation due to refactoring.

Overview
Simplifies TUI UI plumbing and removes dead code by extracting a reusable KeyHintInline (and updating KeyHintBar plus several screens to use it) and by centralizing the shared EMPTY_HINTS constant for screen hint hooks.

Refactors JourneyStepper to use state→glyph/color lookup tables instead of nested ternaries, collapses duplicate imports in ConsoleView, and deletes unused/obsolete components (AmplitudeLogo, CardLayout, SplitView, plus HAlign/VAlign tokens) and their barrel exports.

^{Reviewed by Cursor Bugbot for commit 4fa7077. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Celebration hint loses gap={1} spacing between elements
  • Added an optional gap prop to KeyHintInline and passed gap={1} at the celebration Continue hint call site to restore the original inter-element spacing.

Or push these changes by commenting:

@cursor push 3c758ec12d

Preview (3c758ec12d)

diff --git a/src/ui/tui/components/KeyHintBar.tsx b/src/ui/tui/components/KeyHintBar.tsx
--- a/src/ui/tui/components/KeyHintBar.tsx
+++ b/src/ui/tui/components/KeyHintBar.tsx
@@ -34,8 +34,16 @@
  * one-off hotkey advertisements; the persistent footer bar at the
  * bottom of the layout is `KeyHintBar` itself.
  */
-export const KeyHintInline = ({ hint, label }: { hint: string; label: string }) => (
-  <Box>
+export const KeyHintInline = ({
+  hint,
+  label,
+  gap,
+}: {
+  hint: string;
+  label: string;
+  gap?: number;
+}) => (
+  <Box gap={gap}>
     <Text color={Colors.muted}>[</Text>
     <Text color={Colors.body} bold>
       {hint}

diff --git a/src/ui/tui/screens/DataIngestionCheckScreen.tsx b/src/ui/tui/screens/DataIngestionCheckScreen.tsx
--- a/src/ui/tui/screens/DataIngestionCheckScreen.tsx
+++ b/src/ui/tui/screens/DataIngestionCheckScreen.tsx
@@ -325,13 +325,11 @@
    */
   async function refreshToken(force = false): Promise<boolean> {
     try {
-      const { getStoredToken, getStoredUser, storeToken } = await import(
-        '../../../utils/ampli-settings.js'
-      );
+      const { getStoredToken, getStoredUser, storeToken } =
+        await import('../../../utils/ampli-settings.js');
       const { refreshAccessToken } = await import('../../../utils/oauth.js');
-      const { EXPIRY_BUFFER_MS } = await import(
-        '../../../utils/token-refresh.js'
-      );
+      const { EXPIRY_BUFFER_MS } =
+        await import('../../../utils/token-refresh.js');
       const user = getStoredUser();
       const stored = getStoredToken(user?.id, user?.zone);
       if (!stored || !user) return false;
@@ -450,15 +448,15 @@
         );
         // Fall back to the first org if the stored ID doesn't match (stale checkpoint).
         const org = currentSession.selectedOrgId
-          ? userInfo.orgs.find((o) => o.id === currentSession.selectedOrgId) ??
-            userInfo.orgs[0]
+          ? (userInfo.orgs.find((o) => o.id === currentSession.selectedOrgId) ??
+            userInfo.orgs[0])
           : userInfo.orgs[0];
         // Fall back to the first project if the stored ID doesn't match.
         const project =
           org && currentSession.selectedProjectId
-            ? org.projects.find(
+            ? (org.projects.find(
                 (p) => p.id === currentSession.selectedProjectId,
-              ) ?? org.projects[0]
+              ) ?? org.projects[0])
             : org?.projects[0];
 
         const restoredFields: Parameters<typeof store.restoreSessionIds>[0] =
@@ -948,7 +946,7 @@
 
         <Box marginTop={1}>
           {celebrationReady ? (
-            <KeyHintInline hint="Enter" label="Continue" />
+            <KeyHintInline hint="Enter" label="Continue" gap={1} />
           ) : (
             <Text color={Colors.body}>Verifying{Icons.ellipsis}</Text>
           )}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4fa7077. Configure here.}

[cursor]

Celebration hint loses gap={1} spacing between elements

Low Severity

The old celebration-state "Continue" hint used <Box gap={1}>, which adds 1 character of spacing between each <Text> child (rendering as [ Enter ] Continue). The replacement KeyHintInline uses a plain <Box> with no gap prop (defaults to 0), rendering as [Enter] Continue. This is a subtle visual change despite the PR claiming byte-identical output for every replaced block.

Additional Locations (1)

• src/ui/tui/components/KeyHintBar.tsx#L36-L45

 

^{Reviewed by Cursor Bugbot for commit 4fa7077. Configure here.}