This repository was archived by the owner on Mar 26, 2024. It is now read-only.
Invert GL async swap feature#324
Open
adglkh wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@keirthana This is a feature being part of 1.21.0 release. So let's not publish it until 1.21.0 is released. |
Contributor
@adglkh Sure, but can you raise these changes against the https://github.com/canonical/anbox-cloud-docs repo? This discourse-docs repo is archived and no longer the latest repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have GL Async object enabled from the very beginning after the
bring up work for the emugl decoder is complete, however the consequence
of enabling the GL async swap feature is that a few games/apps got
ANRs due to the fact GL call hangs at the host driver caused by this
enabled feature when swapping buffers.
For a better user experience, since 1.21.0 release, this feature
is disabled for Anbox device by default. And we inverted the feature
flag and environment variable accordingly to honor the behavior change.