Prevent Enter from double-submitting during IME composition#196
Open
leonidasbarkas98-cpu wants to merge 1 commit into
Open
Prevent Enter from double-submitting during IME composition#196leonidasbarkas98-cpu wants to merge 1 commit into
leonidasbarkas98-cpu wants to merge 1 commit into
Conversation
Tracks compositionstart/compositionend on the chat input and skips the Enter-to-send handling while composing (or when e.isComposing is still true), so confirming a CJK IME candidate no longer also sends the message (Gitea issue andrepimenta#2; upstream andrepimenta#146). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When composing text with an IME (Korean/Japanese/Chinese), confirming the composition with Enter also triggered the send handler, so the message was submitted twice (or submitted half-composed). The Enter handler now checks
isComposing/ keyCode 229 and ignores composition-confirming Enter presses.Same idea as PR #146, rebased onto current main (2.2.0).
Fixes #130
Fixes #132
🤖 Generated with Claude Code